Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small tweaks to juliac script and misc fixes to juliac #56119

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

gbaraldi
Copy link
Member

This comments out an assert thats currently faulty and also marks apply_iterate as safe when we can special case it to not dispatch

…apply_iterate as safe when we can special case it to not dispatch
@topolarity topolarity added the trimming Issues with trimming functionality or PR's relevant to its performance/functionality label Oct 11, 2024
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes up a sound-ness hole and also expands the support for Core._apply_iterate so that (vec...,) now works, which is great!

@gbaraldi gbaraldi added the merge me PR is reviewed. Merge when all tests are passing label Oct 21, 2024
@gbaraldi gbaraldi merged commit 6d7e29f into master Oct 21, 2024
5 of 7 checks passed
@gbaraldi gbaraldi deleted the gb/misc-juliac branch October 21, 2024 14:24
gbaraldi added a commit that referenced this pull request Oct 21, 2024
This comments out an assert thats currently faulty and also marks
apply_iterate as safe when we can special case it to not dispatch
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trimming Issues with trimming functionality or PR's relevant to its performance/functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants